fix flushing loggers

[Borda]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?
• If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1447 and #1460.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[Borda]

I will add a tests to cover this usecases over all loggers....

[codecov]

Codecov Report

Merging #1459 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1459   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          67      67           
  Lines        3742    3756   +14     
======================================
+ Hits         3400    3415   +15     
+ Misses        342     341    -1     

[pep8speaks]

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-14 17:19:52 UTC

[Borda]

I have added parametrized test for "fit + test" and "pickle" for all loggers which are running with default

[Borda]

any idea why unrelated test benchmark fails:

        # verify torch.backends.cudnn.benchmark is not turned on
>       assert not torch.backends.cudnn.benchmark
E       AssertionError: assert not True
E        +  where True = <module 'torch.backends.cudnn' from '/home/circleci/.local/lib/python3.6/site-packages/torch/backends/cudnn/__init__.py'>.benchmark
E        +    where <module 'torch.backends.cudnn' from '/home/circleci/.local/lib/python3.6/site-packages/torch/backends/cudnn/__init__.py'> = <module 'torch.backends' from '/home/circleci/.local/lib/python3.6/site-packages/torch/backends/__init__.py'>.cudnn
E        +      where <module 'torch.backends' from '/home/circleci/.local/lib/python3.6/site-packages/torch/backends/__init__.py'> = torch.backends

[neggert]

Is this intended to be commented? If so, why?

[Borda]

I have added this to be the same as other loggers but then it is crashing because the accumulator is missing...
I don't feel like debugging this magic tool, there are already several other things I don't like much...
It have not been even properly tested yet

[Borda]

opened issue here - https://github.community/t5/GitHub-Actions/Hanging-workflow-even-with-successful-tests/m-p/53850#M8988

UPDATE: it was the __del__ in logger which cased the hanging...

[pitercl]

Hi @Borda, it seems that you turned offline_mode on in NeptuneLogger by default. Was this intentional?

If not, how would you like to proceed with restoring the previous default - should I throw a PR or would you like to do it?

[williamFalcon]

@Borda let’s turn the default back on