feat: save checkpoint before deleting old ones #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
======================================
Coverage 91% 91%
======================================
Files 67 67
Lines 3780 3784 +4
======================================
+ Hits 3435 3439 +4
Misses 345 345 |
justusschock
approved these changes
Apr 11, 2020
|
This pull request is now in conflict... :( |
williamFalcon
approved these changes
Apr 16, 2020
|
Great job! =) |
|
any idea why the bot is sending 3 emails? |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* feat: save checkpoint before deleting old ones * fix: make sure that the new model is not deleted * changelog Co-authored-by: J. Borovec <jirka.borovec@seznam.cz> Co-authored-by: William Falcon <waf2107@columbia.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1150 (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭