Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke load_spawn_weights() only in proc with rank 0 #1385

Merged

Conversation

areshytko
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1335 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 5, 2020 23:52
@williamFalcon
Copy link
Contributor

@areshytko awesome! there seems to be a failing doc test @Borda.

@Borda Borda added the bug Something isn't working label Apr 6, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 6, 2020
@Borda
Copy link
Member

Borda commented Apr 6, 2020

yes, pls rebase master

@Borda Borda force-pushed the ddp-load-spawn-weights--1335 branch from 2d1b53b to 1b21c28 Compare April 6, 2020 12:56
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #1385 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1385   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          63      63           
  Lines        3330    3332    +2     
======================================
+ Hits         3057    3059    +2     
  Misses        273     273           

@williamFalcon williamFalcon merged commit 9754c5d into Lightning-AI:master Apr 6, 2020
@Borda
Copy link
Member

Borda commented Apr 6, 2020

missing changelog

@Borda Borda mentioned this pull request Apr 6, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
Co-authored-by: Alexander Reshytko <areshytko@Alexanders-MacBook-Pro.local>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer DDP should invoke load_spawn_weights() only in proc_rank == 0
3 participants