Removes need to unsqueeze from dp #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
changed the title
williamFalcon
changed the title
|
This pull request is now in conflict... :( |
awaelchli
reviewed
Mar 31, 2020
| @@ -199,3 +202,15 @@ def _worker(i, module, input, kwargs, device=None): | |||
| raise output | |||
| outputs.append(output) | |||
| return outputs | |||
|
|
|||
|
|
|||
| def auto_squeeze_dim_zeros(output): | |||
There was a problem hiding this comment.
How about just "unsqueeze_scalars"?
Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch>
|
This pull request is now in conflict... :( |
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
=======================================
+ Coverage 92% 92% +<1%
=======================================
Files 62 62
Lines 3239 3246 +7
=======================================
+ Hits 2964 2971 +7
Misses 275 275 |
|
After this change, is it still needed to suppress this warning? |
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* removes need to unsqueeze from dp * removes need to unsqueeze from dp * fixed examples * added auto unsqueeze * added auto unsqueeze * added auto unsqueeze * added auto unsqueeze * Update pytorch_lightning/overrides/data_parallel.py Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch> * fixed dp parse * fixed dp parse Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.