remove .item which causes sync issues #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Mar 27, 2020
| @@ -0,0 +1,34 @@ | |||
| import torch | |||
There was a problem hiding this comment.
what about creating a metrics package?
There was a problem hiding this comment.
not relevant to this
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
======================================
Coverage 91% 91%
======================================
Files 61 62 +1
Lines 3153 3176 +23
======================================
+ Hits 2879 2901 +22
- Misses 274 275 +1 |
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Mar 30, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 1, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
Borda
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 7, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
williamFalcon
added a commit
that referenced
this pull request
Apr 8, 2020
* `add_argparse_args` method fixed (argument types added) * autopep8 fixes * --gpus=0 removed from test (for ci tests) * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Joe Davison <joe@huggingface.co> * test_with_accumulate_grad_batches added * agg_and_log_metrics logic added to the base logger class * small format fix * agg metrics strategies removed (not to complicate stuff) * agg metrics: handle zero step * autopep8 * changelog upd * flake fix * metrics aggregators factored out, metrics_agg.py added + tests * metrics agg default value added * Update pytorch_lightning/loggers/metrics_agg.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * metrics aggregators factored out, metrics_agg.py added + tests * metrics agg default value added * Update pytorch_lightning/loggers/metrics_agg.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * remove .item which causes sync issues (#1254) * remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched * test_metrics_agg.py removed (all tested in doctrings), agg metrics refactored * test_metrics_agg.py removed (all tested in doctrings), agg metrics refactored * autopep8 * loggers base.py types fixed * test * test * metrics aggregation for loggers: each key now has a specific function (or default one) * metrics aggregation for loggers: each key now has a specific function (or default one) * docstrings upd * manual typehints removed from docstrings * batch_size decreased for test `test_with_accumulate_grad_batches` * extend running accum * refactor * fix tests * fix tests * allowed_types generator scoped * trainer.py distutils was imported twice, fixed * TensorRunningAccum refactored * TensorRunningAccum added to change log (Changed) * change log pull link added Co-authored-by: Joe Davison <joe@huggingface.co> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 10, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 10, 2020
* remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
…AI#1278) * `add_argparse_args` method fixed (argument types added) * autopep8 fixes * --gpus=0 removed from test (for ci tests) * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Joe Davison <joe@huggingface.co> * test_with_accumulate_grad_batches added * agg_and_log_metrics logic added to the base logger class * small format fix * agg metrics strategies removed (not to complicate stuff) * agg metrics: handle zero step * autopep8 * changelog upd * flake fix * metrics aggregators factored out, metrics_agg.py added + tests * metrics agg default value added * Update pytorch_lightning/loggers/metrics_agg.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * metrics aggregators factored out, metrics_agg.py added + tests * metrics agg default value added * Update pytorch_lightning/loggers/metrics_agg.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * remove .item which causes sync issues (Lightning-AI#1254) * remove .item which causes sync issues * fixed gradient acc sched * fixed gradient acc sched * test_metrics_agg.py removed (all tested in doctrings), agg metrics refactored * test_metrics_agg.py removed (all tested in doctrings), agg metrics refactored * autopep8 * loggers base.py types fixed * test * test * metrics aggregation for loggers: each key now has a specific function (or default one) * metrics aggregation for loggers: each key now has a specific function (or default one) * docstrings upd * manual typehints removed from docstrings * batch_size decreased for test `test_with_accumulate_grad_batches` * extend running accum * refactor * fix tests * fix tests * allowed_types generator scoped * trainer.py distutils was imported twice, fixed * TensorRunningAccum refactored * TensorRunningAccum added to change log (Changed) * change log pull link added Co-authored-by: Joe Davison <joe@huggingface.co> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes unecessary syncs in ddp caused by unecessary .item()