Backward compatibility for checkpoint loading #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @amoudgl! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-17 13:56:42 UTC |
Borda
added
bug
Borda
approved these changes
Mar 13, 2020
|
@amoudgl pls add note to changelog... then we can go :] |
amoudgl
added a commit
to amoudgl/pytorch-lightning
that referenced
this pull request
Mar 14, 2020
|
@Borda I have made updates to CHANGELOG, could you please review? |
|
this shall be fixed in #1163 |
|
I see, everything is all set in this PR then? |
|
@amoudgl could you pls update from master? |
|
@Borda I have rebased the PR. |
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
======================================
Coverage 89% 89%
======================================
Files 62 62
Lines 3163 3163
======================================
Hits 2809 2809
Misses 354 354 |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* check if hparams_type exists in checkpoint dictionary for backward compatibility * concisely maintain backward compatibility for hparams type * Bug fix in checkpoint loading (Lightning-AI#1132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
It adds backward compatibility for checkpoint loading. Checkpoint loading is not backward compatible in 0.7.1. Checkpoints saved with previous pl versions (0.6 in my case) do not have
hparams_typein checkpoint dictionary due to which hparams are not converted to namespace (L1399). Thus, pl raises error while loading model class as hparams is passed as dictionary to model class not namespace.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃