Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neptune Logger Improvements #1084

Merged
merged 12 commits into from
Mar 14, 2020
Merged

Neptune Logger Improvements #1084

merged 12 commits into from
Mar 14, 2020

Conversation

jakubczakon
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [] Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Neptune Logger improvement #908

  • added close_after_fit argument that lets you leave the logger open after the trainer.fit(model) finishes. It makes logging test metrics trainer.test(model, images or checkpoints easy via
    generic neptune experiment methods .log_metric, .log_image, .log_artifact.
  • added "ANONYMOUS" token in examples to let people try it out without registering

@pep8speaks
Copy link

pep8speaks commented Mar 7, 2020 •
edited
Loading

Hello @jakubczakon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-03-13 15:14:06 UTC

@jakubczakon
Copy link
Contributor Author

@Borda
I haven't added this option to other loggers as I saw people did some work there already (comet).
I can add this close_after_fit option to other loggers but I just don't want to step into other folks territory (where they may not appreciate me being) :).
It's your call.

@Borda Borda added the feature Is an improvement or enhancement label Mar 7, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 7, 2020
@Borda Borda self-requested a review March 7, 2020 16:31
@Borda
Copy link
Member

Borda commented Mar 11, 2020

hey there, we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖

@jakubczakon
Copy link
Contributor Author

Sure, no worries, I'll work on it.

Borda
Borda approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

  • just add summary to chnagelog

Borda
Borda requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor docs enhancement, then we are ready to go 🤖
pls rebase/merge to resolve conflicts...

pytorch_lightning/loggers/neptune.py Outdated Show resolved Hide resolved
@jakubczakon
Copy link
Contributor Author

I think it's done @Borda

Borda
Borda approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added the ready PRs ready to be merged label Mar 13, 2020
@williamFalcon williamFalcon merged commit 3ad6169 into Lightning-AI:master Mar 14, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@jakubczakon @tullie
Neptune Logger Improvements (Lightning-AI#1084)
48fa06f 
* removed project and experiment from getstate

* added tests for closing experiment, updated token in example to user neptuner

* updated teoken

* Update neptune.py

added a link to example experiment

* added exmaple experiment link

* dropped duplication

* flake fixes

* merged with master, added changes information to CHANGELOG
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubczakon @pep8speaks @Borda @williamFalcon