Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min py3.8 #1021

Merged
merged 32 commits into from
May 31, 2023
Merged

bump min py3.8 #1021

merged 32 commits into from
May 31, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented May 30, 2023

What does this PR do?

As python 3.7 is almost on its EoL we will bump min tested to py3.8

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda
Copy link
Member Author

Borda commented May 30, 2023

seems we need to unfreeze numpy #959 so as not to compile it from the source for GPU's CI

@Borda
Copy link
Member Author

Borda commented May 31, 2023

the same case from google/dopamine#24 (comment)

@Borda Borda merged commit fd27b9e into master May 31, 2023
24 of 25 checks passed
@Borda Borda deleted the req/bump-py3.8 branch May 31, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant