Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeprecationWarning LST20 model to PyThaiNLP 3.1.1 #749

Closed
wannaphong opened this issue Oct 28, 2022 · 4 comments
Closed

Add DeprecationWarning LST20 model to PyThaiNLP 3.1.1 #749

wannaphong opened this issue Oct 28, 2022 · 4 comments
Labels
documentation improve documentation and test cases
Milestone
3.1

Comments

@wannaphong
Copy link
Member

After we delete all LST20 model #728 from dev, I think we should release PyThaiNLP 3.1.1 to add DeprecationWarning about LST20 model.
@wannaphong wannaphong added the documentation improve documentation and test cases label Oct 28, 2022
@wannaphong wannaphong added this to the 3.1 milestone Oct 28, 2022
@noppayut
Copy link
Contributor

Which action would you like when LST20-related options are chosen? Since they're gone we can either

  1. Throw an error, ask users to choose a new option.
  2. Fire a DeprecationWarning and use a default option for an API.

I personally prefer 2.

@wannaphong
Copy link
Member Author

Yes, It will be 2 for PyThaiNLP 3.1.1 that it in 3.1 branch. Now, dev branch is 4.0.

@noppayut
Copy link
Contributor

Cool. Let me work on this.

@wannaphong
Copy link
Member Author

Cool. Let me work on this.

Thank you! You can do this work. Don't forget doing in 3.1 branch.

@noppayut noppayut mentioned this issue Oct 30, 2022
Merged
wannaphong added a commit that referenced this issue Oct 30, 2022
@wannaphong
Merge pull request #752 from noppayut/lst20-deprecation-warning
ddd785d 
Doc: Lst20 deprecation warning for 3.1.1 (#749)
wannaphong added a commit that referenced this issue Oct 30, 2022
@wannaphong
PyThaiNLP 3.1.1
04f783a 
PyThaiNLP v3.1.1 is the releases updates of PyThaiNLP v3.1.0.

-  Add Reduce import time #719 to PyThaiNLP 3.1.1 #753
-  Doc: Lst20 deprecation warning for 3.1.1 (#749) #752
@wannaphong wannaphong mentioned this issue Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation improve documentation and test cases
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@wannaphong @noppayut