Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different FTP LIST locales (Windows CE exclusive?) #438

Closed
atollk opened this issue Nov 4, 2020 · 4 comments · Fixed by #439
Closed

Add support for different FTP LIST locales (Windows CE exclusive?) #438

atollk opened this issue Nov 4, 2020 · 4 comments · Fixed by #439
Labels
Milestone

Comments

@atollk
Copy link
Member

atollk commented Nov 4, 2020

We are using pyfilesystem2 to access a German locale FTP server on an MS Windows CE operating system. I cannot pinpoint whether it is the locale, the OS, or a different factor altogether, but the FTP LIST command, which is apparently used almost everywhere in the library, yields its data in a different format than Windows NT. Thus, FTPFS.read_dir fails to parse any items and always returns an empty dict and most operations fail.

To be precise, the LIST output only differs slightly in that it uses 24 hour days rather than 12 hour AM/PM days.

WinNT:
11-02-18 02:12PM <DIR> images
11-02-18 03:33PM 9276 logo.gif

WinCE:
11-02-18 14:12 <DIR> images
11-02-18 15:33 9276 logo.gif

We would like to see support for that format added, either as an extension to the "WindowsNT" parsing, or as a new kind of response parsing. If this is an acceptable change, we'd create the suitable PR for it. It would be great if this fix would make it into 2.4.12, as we'd have to keep using a custom fix in our code until 2.4.13 otherwise.

Thanks!

@willmcgugan
Copy link
Member

A PR would be appreciated.

@atollk
Copy link
Member Author

atollk commented Nov 5, 2020

Hey, thanks for the quick response. I set up the PR here: #439

@lurch
Copy link
Contributor

lurch commented Nov 5, 2020

OffTopic: FTP on Windows CE? I guess this must be some "legacy system" you're interfacing with? 😉

@atollk
Copy link
Member Author

atollk commented Nov 5, 2020

Don't get me started on that :)
Yeah, that system was sold with a long running support contract, so maintenance still has to be offered even decades after release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants