Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error in "Testing Filesystems" documentation #407

Closed
mjpieters opened this issue Jun 24, 2020 · 1 comment · Fixed by #434
Closed

Minor error in "Testing Filesystems" documentation #407

mjpieters opened this issue Jun 24, 2020 · 1 comment · Fixed by #434
Labels
docs Issues related to documentation
Milestone

Comments

@mjpieters
Copy link

The Implementing Filesystems -> Testing Filesystems section has a minor error in the example:

from fs.test import FSTestCases

class TestMyFS(FSTestCases):

    def make_fs(self):
        # Return an instance of your FS object here
        return MyFS()

FSTestCases is a plain class without anything more than object as a base class, yet it's methods expect unittest.TestCase to be a base, so the above won't work. It's missing an additional base class:

import unittest 
from fs.test import FSTestCases

class TestMyFS(FSTestCases, unittest.TestCase):

    def make_fs(self):
        # Return an instance of your FS object here
        return MyFS()
@lurch
Copy link
Contributor

lurch commented Jun 24, 2020

@althonos althonos added the docs Issues related to documentation label Sep 17, 2020
@althonos althonos added this to the v2.4.12 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues related to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants