Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
getattr(x, 'foo')
andsetattr(x, 'foo', 'bar')
are no moresafe than normal property access and probably cause additional confusion
about safety when they are used because without a default
getattr
raises the same
AttributeError
as dot access. There is also aperformance cost associated with doing attribute access indirectly.
I've added these as separate warnings since they opperate on two
different behaviors but they could probably be combined as a single
"fat" warning without trouble.
Example with
getattr
:Example with
setattr
: