Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Do not automatically continue gathering when revisit procs #117

Open
PrincessRTFM opened this issue Jul 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PrincessRTFM
Copy link

Is your feature request related to a problem? Please describe.
When revisit procs and my effects are cleared, pandora continues gathering without giving me a chance to reapply my (manually chosen) buffs first, and I have to hurry to turn it off, reapply my buffs, and then start gathering again.

Describe the solution you'd like
I would like pandora's auto-gathering to treat revisit triggering as if I opened a new node. If "remember item between nodes" is disabled, it should wait for me to select an item to gather. If not, it should trigger any configured actions and then begin gathering again.

Describe alternatives you've considered
Alternatively, it would be acceptable to simply remember what action buffs I had active before revisit and apply them again, then continue gathering. This would be potentially less useful, as it would assume that the exact same item is desired, and it's possible that the "original" node hits were sufficient to gather the desired materials, at which point I usually prefer to gather a handful of crystals instead, but it would at least work as desired in most cases.

Additional context
If the alternative is implemented, single-hit buffs could complicate matters. Since GP is restored, it may be desirable to use the visit-long version instead.

@PrincessRTFM PrincessRTFM added the enhancement New feature or request label Jul 25, 2024
@Taurenkey
Copy link
Collaborator

It technically does already treat it like a new node. Revisit is a tricky one because the best way to detect it is through chat messages, so what Pandora does is when it detects a certain message type at 0 durability it will run the same code that is run on opening a node. So to that effect, if you've already turned off Remember Item then it should not gather until you click it again on a revisit. If it's not doing this then it's a bug which is really hard to test given the nature of revisit (I've been trying to proc it whilst writing this with no luck).

Pandora gathering logic isn't super deep and is designed for mindless gathering. The intention was to emulate the quick gather from the game but using abilities to increase yield. Anything beyond a bug fix at this point is beyond the scope of the feature and would be better suited in a plugin of its own.

I will continue to try and proc revisit in the meantime to investigate the Remember Item claim.

@PrincessRTFM
Copy link
Author

It's definitely not working for me, I'm afraid. I have all options disabled except for pandora gathering itself, and opening a new node waits for me to select an item, but twice now I've gotten revist to proc and pandora has simply continued gathering without pause. I didn't know there was handling in place for it, or I'd have filed this as a bug to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants