Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ipfs #251

Merged
merged 1 commit into from
Jul 8, 2019
Merged

chore: update ipfs #251

merged 1 commit into from
Jul 8, 2019

Conversation

fsdiogo
Copy link
Collaborator

@fsdiogo fsdiogo commented Jul 4, 2019

  • Update to the latest version of IPFS
  • Update the hashes to base32 to pass validations
  • Remove unneeded webpack configs

@fsdiogo fsdiogo self-assigned this Jul 4, 2019
@terichadbourne
Copy link
Member

Thanks for this @fsdiogo! I've updated my npm packages and run locally and it seems to be in good order after testing just a few lessons. Can I assume that @olizilla's robot means I don't need to do any more specific checks? Or do I need to run through the file upload ones by hand?

This shouldn't change the 'passed' status of people who already submitted when it worked the other way, right?

@terichadbourne
Copy link
Member

@fsdiogo Have you already checked whether this version of IPFS includes the blob support in the browser? Is that resolved here or should we leave a separate issue open for it?

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Jul 8, 2019

Or do I need to run through the file upload ones by hand?

I ran it by hand just to safeguard and everything worked out as expected, so this one is good to go!

Have you already checked whether this version of IPFS includes the blob support in the browser? Is that resolved here or should we leave a separate issue open for it?

I haven't tested it, but it should be done: ipfs/js-ipfs#2024

@terichadbourne
Copy link
Member

Perfect, thanks for taking this one on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants