Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code reuse #6

Merged
merged 2 commits into from
Aug 7, 2024
Merged

code reuse #6

merged 2 commits into from
Aug 7, 2024

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Aug 7, 2024

Pulling adjust_pop_grids into it's own module.

Copy link

github-actions bot commented Aug 7, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 96e6825
✅ Deployment Preview URL: https://ProjectPythia.github.io/ocean-bgc-cookbook/_preview/6

@jukent
Copy link
Contributor Author

jukent commented Aug 7, 2024

NOAA site seems to be down for scheduled maintenance today, hence link failing

Copy link
Member

@rmshkv rmshkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this adjustment, Julia! This looks a lot cleaner than I originally had it.

@jukent
Copy link
Contributor Author

jukent commented Aug 7, 2024

Great. Thanks again for all your hard work @rmshkv !

@jukent jukent merged commit a529c1d into ProjectPythia:main Aug 7, 2024
1 of 2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
@erogluorhan
Copy link
Member

Thanks a lot for the great content, @rmshkv , and thorough review and cleaning touchups, @jukent ! Apart from its content, this is also going to be a nice example of how to implement code for cookbook in one place and reuse and display them nicely in several chapters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants