Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move License and Theme to Footer v2 #172

Merged
merged 8 commits into from
May 14, 2024
Merged

Conversation

jukent
Copy link
Contributor

@jukent jukent commented May 14, 2024

This is more in line with how Pythia foundations handles the extra footer information. Instead of #115

Related to ProjectPythia/pythia-foundations#397

Copy link

github-actions bot commented May 14, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 2e9d040
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/172

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick suggestions.

_templates/footer-extra.html Outdated Show resolved Hide resolved
jukent and others added 2 commits May 14, 2024 12:37
@jukent jukent requested a review from brian-rose May 14, 2024 18:41
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jukent
Copy link
Contributor Author

jukent commented May 15, 2024

There seems to be a repeated footer before the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants