Adding Linker Metadata #3038
Merged
Adding Linker Metadata #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
dev/ds/link-updates
branch
from
24a33b0
to
899eb64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds polyfills for backwards compatibility with legacy targets such as net4.x and netstandard.
This updates a number of Generic APIs where we make use of the Container to resolve types to provide the DynamicallyAccessedMembers attribute to help provide the .NET Linker with additional metadata to prevent it from removing the constructors that would be used by DI. Similarly we have updated the Prism Containers to do the same.
This should help reduce issues that are encountered when enabling linking regardless of which platform you are building for.
API Changes
No public API's have explicitly been changed however a number of public API's with Generic Arguments have had an additional attribute added to provide context to the .NET Linker.
Behavioral Changes
Prism now actively discourages linking for constructors and of itself.