Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IActiveAware activates inactive views #2848

Merged
merged 4 commits into from
Apr 24, 2023
Merged

IActiveAware activates inactive views #2848

merged 4 commits into from
Apr 24, 2023

Conversation

dansiegel
Copy link
Member

Description of Change

This updates the behaviors to help ensure that we do not accidently mark a View/ViewModel as active when it technically is not. For instance in the case where a NavigationPage is child of a TabbedPage. The NavigationPage may not be the active tab of the TabbedPage while the CurrentPage of the NavigationPage will still be marked as active.

This ensures that all children of the NavigationPage are in fact not active in this scenario.

Bugs Fixed

API Changes

n/a

Behavioral Changes

Adds additional checks before setting IActiveAware.IsActive

@dansiegel dansiegel merged commit 17d20e9 into master Apr 24, 2023
@brianlagunas brianlagunas deleted the active-aware-fix branch April 24, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveAware is called more than needed
2 participants