Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dialogservice invoking OnNavigatedTo method #2589

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

brianlagunas
Copy link
Member

Description of Change

When closing a dialog that was opened using the IDialogService, the INavigationAware.OnNavigatedTo method would be invoked.

This fixed that behavior. No, none of the InavigatinAware methods are invoked when closing a dialog.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit 2152c88 into master Oct 15, 2021
@dansiegel dansiegel deleted the issue-2588 branch October 15, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants