Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: DispatcherQueue property moved across name spaces. WinUI 3 API … #2530

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

sigmarsson
Copy link

In Reunion 0.8 DispatcherQueue moved from the Microsoft.System to the Microsoft.UI.Dispatching namespace. The error indicates this version of Prism is still using the old namespace and needs to be updated for 0.8.

#2523

## Description of Change

Describe your changes here.

Name space harmonization with WinUI 3 0.8

Bugs Fixed

microsoft/microsoft-ui-xaml#5601

  • Provide links to bugs here

API Changes

List all API changes here (or just put None), example:

Added:

  • void INavigationService.GoBackToRootAsync();

Changed:

  • void INavigationService.GoBackAsync => bool INavigationService.GoBackAsync

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dnfadmin
Copy link

dnfadmin commented Aug 13, 2021

CLA assistant check
All CLA requirements met.

@dansiegel
Copy link
Member

@sigmarsson please be sure to sign the DNF CLA as we will not be able to merge anything from you until you have signed the CLA.

@dansiegel
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dansiegel
Copy link
Member

After pulling this locally the reason it's failing is quite valid. The namespace Microsoft.UI.Dispatching does not exist for the Uno.WinUI Android, macOS, & iOS targets. The issue is on line 35 of the DependencyObjectExtensions.Uno.cs, and is only an issue for those targets due to the fact that it's only for those targets that it meets the compiler directive to be an issue. This will need to be fixed before we can merge.

@sigmarsson
Copy link
Author

@dansiegel , thanks !

@dansiegel dansiegel merged commit 281535d into PrismLibrary:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants