Don't restore env.code from backupCode in Handlebars, PHP and Smarty … #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this does fix #997. |
Golmote
added a commit
that referenced
this pull request
Sep 1, 2016
…lugins in the before-sanity-check hook. Fix #1018 (see issue for discussion)
thesave
added a commit
to thesave/prism
that referenced
this pull request
Sep 2, 2016
* PrismJS/gh-pages: Autoloader plugin: don't try to load "none" component. Fix PrismJS#1000 Optimized block regexps to prevent struggling on large files. Fixes PrismJS#1001 Revert PrismJS#998 + run normalize-whitespace and remove-initial-line-feed plugins in the before-sanity-check hook. Fix PrismJS#1018 (see issue for discussion) Run gulp # Conflicts: # plugins/autoloader/prism-autoloader.min.js
mAAdhaTTah
added a commit
to mAAdhaTTah/prism
that referenced
this pull request
Oct 8, 2016
* gh-pages: (107 commits) Reverse prism markup min JSON: Fixed issues with properties and strings + added tests. Fix PrismJS#1025 Fix grammar in Readme Update CHANGELOG Update APL minified file + update test for iota underbar function Add iota underbar (PrismJS#1024) Fix typo `Fload` to `Float` in prism-ruby.js (PrismJS#1023) Autoloader plugin: don't try to load "none" component. Fix PrismJS#1000 Optimized block regexps to prevent struggling on large files. Fixes PrismJS#1001 Revert PrismJS#998 + run normalize-whitespace and remove-initial-line-feed plugins in the before-sanity-check hook. Fix PrismJS#1018 (see issue for discussion) Run gulp Makes CSS strings greedy. Fix PrismJS#1013 update min file and reverse core add prefix feature for custom class plugin Make doctype case insensetive (PrismJS#1009) Optimize images (PrismJS#1007) Restore `viewBox` to Prism logo (PrismJS#1002) Remove unneeded prefixed CSS (PrismJS#989) Fix WPD plugin's page Fix WPD at-rule detection + don't process if language is not handled + fix plugin's page ... # Conflicts: # plugins/show-language/prism-show-language.css # plugins/show-language/prism-show-language.js # plugins/show-language/prism-show-language.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…components.
The PHP component used to store
env.codein abackupCodeproperty in thebefore-highlighthook and restore it in thebefore-inserthook. Both the Handlebars component and the Smarty component copied this behaviour.I don't see any reason to do this currently, though. It seems it was made to work properly with the Line numbers plugin but it actually breaks it when used in conjunction with the Remove initial line feed plugin or the Normalize whitespace plugin...
The Line numbers plugins runs on the
completehook, which gets executed after theafter-highlighthook, so the code used to compute the line numbers is the correct one.This PR should fix #997 and probably fix #935.