Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestAnimationFrame #987

Closed
isglass opened this issue Jun 30, 2016 · 2 comments
Closed

requestAnimationFrame #987

isglass opened this issue Jun 30, 2016 · 2 comments

Comments

@isglass
Copy link

isglass commented Jun 30, 2016

Hi,

Some of our visitors seem to use browsers lacking support for requestAnimationFrame. We highlight on demand so it is not needed for them. Propose the following fix:

requestAnimationFrame(_.highlightAll, 0);

Changed to:

if (window.requestAnimationFrame) window.requestAnimationFrame(_.highlightAll, 0);

Regards,
Johan

@Golmote
Copy link
Contributor

Golmote commented Jun 30, 2016

I'd rather fallback on setTimeout since we're supposed to support IE9.

@zeitgeist87
Copy link
Collaborator

Do we really have to support IE9? We could also simply add a polyfill for requestAnimationFrame to the ie8 plugin, or create an ie9 plugin with the polyfill...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants