Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all grammars as a Zip directly from the Autoloader plugin page #981

Merged
merged 2 commits into from
Jul 4, 2016

Conversation

Golmote
Copy link
Contributor

@Golmote Golmote commented Jun 18, 2016

See #960 for details.

@zeitgeist87
Copy link
Collaborator

I've tested it in multiple browsers and it works really great! Amazing what you can do with JavaScript.

I've noticed one minor thing: You added <script src="components.js"></script> twice. Other than that it is ready to be merged.

@zeitgeist87
Copy link
Collaborator

We could also add all the third party libs to package.json and copy them over with gulp. For example add this to package.json:

    "jszip": "^3.0.0",
    "file-saver": "^1.3.2"

and this to gulp:

gulp.task('vendor', function () {
    return gulp.src([
            './node_modules/jszip/dist/jszip.min.js',
            './node_modules/file-saver/FileSaver.min.js'
        ])
        .pipe(gulp.dest('vendor/'));
});

What do you think?

@Golmote
Copy link
Contributor Author

Golmote commented Jul 3, 2016

I've noticed one minor thing: You added <script src="components.js"></script> twice.

Woops! Nice catch.

We could also add all the third party libs to package.json and copy them over with gulp.

We probably could. But we did not do it for es6-promises. Should we? I don't see the real benefits here.

@zeitgeist87
Copy link
Collaborator

We probably could. But we did not do it for es6-promises. Should we? I don't see the real benefits here.

On the one hand, it would make it easier to keep these libs up to date. On the other hand, every second PR would probably contain changes to these files, because people don't know how to use git 😄.

You're right it's probably not a good idea.

@Golmote
Copy link
Contributor Author

Golmote commented Jul 4, 2016

Anyway, we'll be able to change this anytime in the future if we feel the need ;). I'm merging.

@Golmote Golmote merged commit 0d0a007 into PrismJS:gh-pages Jul 4, 2016
@Golmote Golmote deleted the autoloader-download-all branch July 4, 2016 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants