Remove Clike dependency from Bash #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bash language is actually very different from Clike. Only 'boolean', 'operator' and 'punctuation' are shared between them. 'operator' and 'punctuation' should be changed in the future, because Bash actually has slightly different operators. Since they share almost nothing, it makes sense to remove the dependency. This patch copies 'boolean', 'operator' and 'punctuation' from Clike, but doesn't change them. This patch also fixes a typo and adds the missing built-in keyword `let`. `let` is not in the POSIX-standard, but Bash and some other shells support it.
zeitgeist87
force-pushed
the
BashString
branch
from
061bb01
to
9acaaa1
Compare
Golmote
added a commit
that referenced
this pull request
Oct 3, 2015
Remove Clike dependency from Bash
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bash language is actually very different from Clike. Only
'boolean', 'operator' and 'punctuation' are shared between them.
'operator' and 'punctuation' should be changed in the future,
because Bash actually has slightly different operators.
Since they share almost nothing, it makes sense to remove the
dependency. This patch copies 'boolean', 'operator' and
'punctuation' from Clike, but doesn't change them.
This patch also fixes a typo and adds the missing built-in keyword
let.letis not in the POSIX-standard, but Bash and some othershells support it.