Handlebars: support block names with dashes (or other special characters) #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfelbox
changed the title
Golmote
added a commit
that referenced
this pull request
Jun 12, 2015
Handlebars: support block names with dashes (or other special characters)
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as mentioned in #586 blocks with dashes should be supported.
As I was searching for a list of allowed characters in block names I couldn't find anything in the short time I was looking (
{{#this-is_ällowed✓-yep}} .. {{/this-is_ällowed✓-yep}}).This hints in the direction that any valid object key is allowed, but whitespace is obviously not allowed (as Handlebars couldn't determine whether this is still the block name or already an argument). So I went for
\S, as basically only whitespace would error out (which was confirmed by my quick tests).Fixes #586