add dockerfile highlighting #576
Conversation
| 'keyword': { | ||
| pattern: /^\s*\b(ONBUILD|FROM|MAINTAINER|RUN|EXPOSE|ENV|ADD|COPY|VOLUME|USER|WORKDIR|CMD|ENTRYPOINT)\b\s/mi | ||
| }, | ||
| 'string': /("|')(\\\n|\\?.)*?\1/, |
There was a problem hiding this comment.
Please be careful with the indentation. Prism uses tabs to indent, not spaces.
|
Thanks for contributing! Would you mind taking a look at my comments? |
| }, | ||
| 'string': /("|')(\\\n|\\?.)*?\1/, | ||
| 'comment': /#[^\n]+/, | ||
| 'punctuation': /([:[\]{}\-,|>?]|---|\.\.\.)/ |
There was a problem hiding this comment.
No need for the parentheses here.
|
Thanks for the awesome feedback. I updated the PR with all of the requested updates. Let me know if there's anything else! |
|
@JustinBeckwith Sorry for the delay. Your updates look good to me. You did not add the |
|
That was an oversight :) Thanks again! |
|
Ohh exactly what I was looking for, any idea when it will be merged? (As I'm currently using bower so its nifty if I don't have to modify files within bower components) /BR |
No description provided.