Add Textile language #544
Merged
Add Textile language #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-textile Conflicts: components.js
| Prism.languages.textile['phrase'].inside['image'].inside['modifier'].inside = Prism.util.clone(modifierTokens); | ||
|
|
||
| // Allow some nesting | ||
| Prism.languages.textile['phrase'].inside['inline'].inside['bold'].inside = { |
There was a problem hiding this comment.
Wow, a lot of repetition here. Why not define one object and clone it?
…m-textile Conflicts: components.js
|
@LeaVerou It should be more DRY now. Does it look good to you? |
Conflicts: components.js
|
Is cloning really needed? So what if they refer to the same object? It’s not like it’s mutated at any point. |
|
Well, I do not mutate it in any way but a plugin could. The last time I forgot to clone duplicated parts of the grammar, bad things happened (remember #469), so I thought prevention was better than cure. |
Conflicts: components.js
Conflicts: components.js
…x phrases, fix image title, simplified regexps, simplified nesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview of the examples: