Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Previewers popup is visible across themes #3080

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

hoonweiting
Copy link
Contributor

Some themes set a positive z-index for some of their parts, such as the .tokens in Twilight. This makes the Previewers popup appear underneath the code, which is silly. This PR sets a higher z-index for the popup itself (10), so theme creators can still play around with z-index in their themes, without obscuring the popup if the Previewers plugin were to be used.

This closes #3074.

@github-actions
Copy link

No JS Changes

Generated by 🚫 dangerJS against a611c13

@hoonweiting
Copy link
Contributor Author

I kinda forgot this isn't prism-themes, so I'm not sure if I need to run npm run build?

@RunDevelopment RunDevelopment merged commit c7b6a7f into PrismJS:master Sep 15, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @hoonweiting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code appears on top of Previewers popup when Twilight theme is used
2 participants