Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2824.
If
clipboard.writeText
fails for any reason, the implementation will now use the fallback method before. This should work around the permission problem in iFrames. I am aware that what I just said means: "this will circumvent browser security measurements," but there's not much I can do about it. The API that is supposed to be used to request access (in a secure way) is still a working draft and only supported by one browser engine.Even though libraries like clipboard.js only use the fallback method, I think we should still keep
clipboard.writeText
. The fallback uses deprecated non-standard methods, so I believe that it's a good idea to haveclipboard.writeText
around in case a browser removesexecCommand
in the future.