Core: Add tabindex to code blocks
#2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2695.
I tested it with all plugins and it works with all of them (almost).
Code blocks with error messages produced by JSONP Highlight and File Highlight do not get a
tabindex=0because of this condition. It's probably acceptable since these error messages are only one line.This change is also incompatible with the Coy theme, Coy code blocks are not tab-able even with the
tabindexadded. Coy uses thecodeelement as its block and not thepreelement as all other themes do. This causes various problems. Frankly, I consider this as yet another bug related to Coy's special layouting. We should seriously think about changing Coy to fix this.