Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Stricter components.json tests #2758

Merged

Conversation

RunDevelopment
Copy link
Member

This adds 3 new tests for components.json that should make reviewing easier.

  1. alias, optional, require, and modify are now checked for single-element arrays. Instead of using "alias": ["foo"] it will suggest to use "alias": "foo".
  2. Alias titles are now validated. It's checked that:
    1. The alias of an alias title is in the alias list.
    2. Each alias title is different from title.
  3. All entries are now checked for unknown properties to prevent typos.

@github-actions
Copy link

github-actions bot commented Feb 12, 2021

No JS Changes

Generated by 🚫 dangerJS against 058061d

@RunDevelopment RunDevelopment merged commit 933af80 into PrismJS:master Mar 17, 2021
@RunDevelopment RunDevelopment deleted the stricter-components-json-tests branch March 17, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant