-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make copy-to-clipboard configurable with multiple attributes #2723
Make copy-to-clipboard configurable with multiple attributes #2723
Conversation
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +22 B (+1.9%).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @edukisto!
A few nits. Also, please add some documentation on how to use the feature you implemented.
I had to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a few words on the Copy to Clipboard plugin page to explain how to use the new localization method. Maybe make it a new section? It doesn't have to be much. Just explain that these attributes are inherited from ancestor nodes, what attributes there are, and what they do.
Sure, I remember the first request. Thank you very much for your advices! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good and very detailed documentation! Yay!
A few minor nits and we're ready to go from what I see.
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
@mAAdhaTTah What about you?
@RunDevelopment I'm into this but need some time to review. Will try to get to it this evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this. I think we're just waiting on the verification of the Russian "Copied!" translation and then we're gtg.
@mAAdhaTTah You think it's good to go? |
@RunDevelopment Yup! :) @edukisto Thank you contributing! |
@RunDevelopment and @mAAdhaTTah, thank you! |
Resolves #1438.
Makes the
copy-to-clipboard
plugin consider the following HTML attributes:data-prismjs-copy
,data-prismjs-copy-error
,data-prismjs-copy-success
,data-prismjs-copy-timeout
.