-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell session: Commands prefixed with a path are now detected #2686
Shell session: Commands prefixed with a path are now detected #2686
Conversation
["builtin", "exit"] | ||
]] | ||
]] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the npm run test:languages -- --accept
command to insert the token stream. With or without final new line, I don't mind, but if it's something that bothers you, then I'll change the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol it doesn't really bother me but I've noticed you making that change elsewhere so I figured we wanted consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh kk. I only make that change everywhere because I configured my IDE that way.
If we really want that consistency, then I'll just reformat all test files. Only takes a second but will probably change ~500 files. Maybe it's not that necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtg w/ nit
This fixes #2685.