Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Extras: Highlight import and export bindings #2533

Merged

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Aug 27, 2020

This wraps the binding declarations of import/export statements.


@karlhorky
This should also work for you, right?

image

@karlhorky
Copy link
Contributor

LGTM, thanks!

@RunDevelopment RunDevelopment merged commit c51abab into PrismJS:master Aug 27, 2020
@RunDevelopment RunDevelopment deleted the js-extras-imports-exports branch August 27, 2020 21:51
karlhorky added a commit to karlhorky/prismjs-vs-code-dark-theme-fix that referenced this pull request Aug 28, 2020
@mAAdhaTTah
Copy link
Member

maybe-class-name seems a bit odd to me. What's the idea here?

@karlhorky
Copy link
Contributor

I think that's not new - looks like it was added in #1743

@RunDevelopment
Copy link
Member Author

Yes, it's been there for a while. The idea is that class names are usually written in pascal case, so we can use this naming convention. However, it's not perfect, so I didn't want to name it "class-name".

@mAAdhaTTah
Copy link
Member

Thanks for the clarification!

quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@karlhorky
Copy link
Contributor

@RunDevelopment @mAAdhaTTah could we have this also published as a new version of prismjs?

Version 1.21.0 (current version as of 8 Oct 2020) doesn't include this change: https://unpkg.com/browse/prismjs@1.21.0/components/prism-js-extras.js

@RunDevelopment
Copy link
Member Author

Well, it's been 2 months since the last release.

@mAAdhaTTah I'll prepare the changelog.

@mAAdhaTTah
Copy link
Member

@karlhorky @RunDevelopment v1.22.0 has been published.

@RunDevelopment
Copy link
Member Author

@mAAdhaTTah Thanks!

On that note: Should we include all changes in the GH release notes? I always removed/didn't include them because I don't want to maintain two copies of the same thing. How do we want to handle this going forward? Always/never include the changes or just have a link to our changelog in the release notes?

@mAAdhaTTah
Copy link
Member

@RunDevelopment That makes sense, just do it in the Changelog.

@karlhorky
Copy link
Contributor

Cool, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants