JSDoc: Fixed line ends #2523
Merged
JSDoc: Fixed line ends #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
approved these changes
Aug 17, 2020
|
It does depend on the line ends of the input file. If the input file uses LF, everything will be fine but under Windows, you can configure git to checkout code and convert the line ends to CRLF (which is the default I think?). Also, it doesn't generate CRLF from LF. It generates CR from CRLF which is the problem. |
|
@mAAdhaTTah Is this good to merge? |
|
Yeah go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two recent pull requests, we had this issue.
This is a temporary fix to adjust the wrong line ends until the issue is fixed upstream.
I would like to merge this soon because it can really hinder contributors because is prevents the CI from passing (which is a requirement to merge any pull request).
@mAAdhaTTah