Remove self & document from IIFE arguments #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If self or document don't exist, they'll error instead of getting to the checks. Fixes #2257.
mAAdhaTTah
force-pushed
the
issue-2257-fix-keep-markup
branch
from
37c8b1e
to
89bb46f
Compare
RunDevelopment
approved these changes
Mar 21, 2020
|
@RunDevelopment @mAAdhaTTah Hey guys, will there be a patch published or how does this work? While on localhost it's possible to manually delete the buggy parts from node_modules, when deploying npm install is still broken... An idea of when this could be live or what to do to have this running would be much appreciated 🙌 🙏 |
|
We will make a release soon but it might take some time. In the meantime, you can let npm checkout the commit instead. |
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
If self or document don't exist, they'll error instead of getting to the checks. Fixes PrismJS#2257.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If self or document don't exist, they'll error instead of getting to the
checks.
Fixes #2257.