Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LLVM IR #2221

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Conversation

porglezomp
Copy link
Contributor

LLVM IR has tons of keywords, has prefixed variables, and is relatively unstable, so it makes sense to consider everything outside of a small set of exceptions to be keywords.

Fixes #2109

@RunDevelopment
Copy link
Member

I will review this shortly.

In the mean-time: The build doesn't pass because some of the generated files weren't updated.
Please run npx gulp to rebuild Prism properly and update/create all minified files.

@porglezomp
Copy link
Contributor Author

Ah thanks, I wasn't sure if they should be checked in for conflict reasons. I went and looked at some other older language additions and didn't see those files being updated at the time so I wasn't sure.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this language definition @porglezomp!

I left you a few comments with questions and suggestions for certain patterns. Also, please add a boolean pattern matching true and false.

tests/languages/llvm/langref-module-example.test Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
LLVM IR has tons of keywords, has prefixed variables, and is relatively
unstable, so it makes sense to consider everything outside of a small
set of exceptions to be keywords.
@porglezomp
Copy link
Contributor Author

Thanks for your detailed review, sorry for the delay in making those changes.

@porglezomp porglezomp force-pushed the llvm-ir branch 2 times, most recently from da909d4 to 7368fd4 Compare March 23, 2020 18:39
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up again!

Just a few more things and we can merge this.

components/prism-llvm.js Outdated Show resolved Hide resolved
components/prism-llvm.js Outdated Show resolved Hide resolved
tests/languages/llvm/edge-cases.test Outdated Show resolved Hide resolved
@RunDevelopment RunDevelopment merged commit 43efde2 into PrismJS:master Mar 23, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @porglezomp!

@porglezomp porglezomp deleted the llvm-ir branch March 24, 2020 02:07
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Request: LLVM IR
2 participants