-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Concurnas support #2206
Add Concurnas support #2206
Conversation
Concurnas is an open source JVM programming language designed for building reliable, scalable, high performance concurrent, distributed and parallel systems. For more information please see: https://concurnas.com/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jasontatton for providing this language definition.
I left you a few comments for further improvements. Also, are there any plans to add support for code in strings?
Bugfixes: + remove g from function pattern + sorted the keyword list + inlined operator + removed unecisary use of insertBefore + added short literal support + lots of fixes to Strings + Improved rule for langExtensions greatly - must be prefixed with the extension name + fixed operator list + removed whitespace Improved tests and example.html
Hello, thank you for taking the time to review this PR and especially for going into the documentation for Concurnas and pointing out a lot of things which I forgot/implemented incorrectly (btw I hope you like Concurnas as a language and I'd love to receive your advice on how it can be improved). I have now fixed the things raised and a few more. Bugfixes:
Also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good now!
Some minor nits and then we can merge this.
Minor changes as requested: + Improved langext pattern + Used inside: Prism.languages.concurnas
Thank you for contributing @jasontatton! |
Concurnas is an open source JVM programming language designed for building reliable, scalable, high performance concurrent, distributed and parallel systems. For more information please see: https://concurnas.com/