Add Concurnas support #2206
Merged
Add Concurnas support #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurnas is an open source JVM programming language designed for building reliable, scalable, high performance concurrent, distributed and parallel systems. For more information please see: https://concurnas.com/
RunDevelopment
requested changes
Feb 10, 2020
There was a problem hiding this comment.
Thank you @jasontatton for providing this language definition.
I left you a few comments for further improvements. Also, are there any plans to add support for code in strings?
Bugfixes: + remove g from function pattern + sorted the keyword list + inlined operator + removed unecisary use of insertBefore + added short literal support + lots of fixes to Strings + Improved rule for langExtensions greatly - must be prefixed with the extension name + fixed operator list + removed whitespace Improved tests and example.html
|
Hello, thank you for taking the time to review this PR and especially for going into the documentation for Concurnas and pointing out a lot of things which I forgot/implemented incorrectly (btw I hope you like Concurnas as a language and I'd love to receive your advice on how it can be improved). I have now fixed the things raised and a few more. Bugfixes:
Also:
|
RunDevelopment
requested changes
Feb 13, 2020
Minor changes as requested: + Improved langext pattern + Used inside: Prism.languages.concurnas
RunDevelopment
approved these changes
Feb 14, 2020
|
Thank you for contributing @jasontatton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurnas is an open source JVM programming language designed for building reliable, scalable, high performance concurrent, distributed and parallel systems. For more information please see: https://concurnas.com/