-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Factor #2203
Add Factor #2203
Conversation
848b923
to
028a9dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @catb0t for making this language definition!
I left you a few comments on how to further improve the language definition and other minor things.
Also, please don't force-push if possible. It prevents me and others from seeing what changed. We will squash and merge at the end, so make as many commits as you like.
So many upstream projects insist that contributors squash before they will merge/rebase, I forget that anyone does differently. I would rather not force-push too. |
|
…y appear after the "! " space character
- 'regexp' vocabulary syntax support for R/ <regexp>/ - 'multiline' vocab syntax support: - ![[ ]] and ![==[ ]==] comments - /* C-like comments */ - [[ ]] and [==[ ]==] strings - HEREDOC: marker ... marker and STRING: name ... ; - string improvements - 'inside' highlighting improvements
(Sorry for force-push, fixing components.js merge conflict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Lots of changes.
I forgot about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits but apart from that, I think it's ready to go.
(Also, please rebuild. That's why the build fails.)
tests/languages/factor/other_builtin_parsing_words_feature.test
Outdated
Show resolved
Hide resolved
Thank you for contributing @catb0t! |
Thank you for your incredible patience, and also universal knowledge of regex, @RunDevelopment! |
Factor language
Example