Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some of the problems OpenCL C had were caused by C, I fixed them there. This also has the added benefit that some of the fixes in C also apply for languages derived from C (e.g. C++).
Changes
C:
__attribute__
declaration.__attribute__
. This is a compiler-specific keyword and while I don't think Prism should include ever compiler-specific keyword, it seemed strange to support__attribute__((...))
betweenstruct
and the name of the structure but not the keyword itself.(
. This fix is also visible in C++.OpenCL C:
function-opencl-kernel
token. I honestly don't know why this was added in the first place. All functions in C are highlighted by the preceding(
, so there's no need for another huge list to maintain.