Include Java keyword record
#2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 14 ships with [JEP 359], which defines a new keyword `record`. [JEP 359]: https://openjdk.java.net/jeps/359
RunDevelopment
requested changes
Jan 17, 2020
There was a problem hiding this comment.
Thank you for making this pull request!
It's basically good as-is aside from two things:
- Please run
gulp(our build process) by running the commandnpm ci && npx gulp. - Please add this to Java's keyword test of our test suite.
|
Hi @RunDevelopment, sorry for not reacting to your request, but I just don't have the time to wrap my head around an unknown project. Thank you very much for cleaning this up and merging. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 14 ships with JEP 359, which defines a new keyword
record.