AQL: More pseudo keywords #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the most common types of false negatives in Prism, so I wouldn't worry too much about it. As you said, it's unlikely to occur. Regarding I think that language definition is ready to merge but we'll have to adjust the tests before that. Please add your new keywords to the keyword test. (More infos on test files.) |
|
Cool, will add the tests, probably tomorrow. |
|
@RunDevelopment I added some more tests |
monotykamary
added a commit
to monotykamary/vscode-aql
that referenced
this pull request
Nov 21, 2019
queryShowcase test query was taken from PrismJS/prism#2055 (reference from Simran-B)
monotykamary
added a commit
to monotykamary/vscode-aql
that referenced
this pull request
Nov 21, 2019
queryShowcase test query was taken from PrismJS/prism#2055 (reference from Simran-B)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #2047, I want to add some more pseudo-keywords:
COLLECT … WITH COUNT INTO …array[* FILTER CURRENT.value == 1 RETURN CURRENT]COLLECT … INTO … KEEP …FOR v IN 1..5 OUTBOUND "verts/1" edges PRUNE conditions …I tried to avoid false-positives by detecting
COUNTbased on the surrounding keywords, but this is in exchange for false-negatives (it won't be detected if comments are inserted in between, which is unlikely however).For
OPTIONSI attempted something similar (it must be followed by an object literal, variables/expressions are not excepted in this position) , but I'm not sure if it's worth it. Let me know what you think.