HTTP: Improved content highlighting #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the tests, I like this change. I'll have to dig through the regexes to give this a full review. |
ggrossetie
pushed a commit
to ggrossetie/prism
that referenced
this pull request
Mar 11, 2019
Extends the content highlighting capabilities of HTTP.
1. Add support for `application/javascript` and `text/css` content types.
2. Change the languages associated with certain types:
1. `application/json` now uses `json` with `javascript` as a backup instead of just `javascript`.
2. All XML types now use `Prism.languages.xml` instead of `markup`.
3. The HTML type now uses `html` instead of `markup`.
3. Add support for highlighting based on [suffixes](https://en.wikipedia.org/wiki/Media_type#Suffix) for XML and JSON.
E.g. `image/svg+xml`, `application/xhtml+xml`, `application/atom+xml` will use `xml` and `application/calendar+json` will use `json`.
4. Stylistic changes:
1. Fix indentation.
2. Use single quotes for token names.
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the content highlighting capabilities of HTTP.
application/javascriptandtext/csscontent types.application/jsonnow usesjsonwithjavascriptas a backup instead of justjavascript.Prism.languages.xmlinstead ofmarkup.htmlinstead ofmarkup.E.g.
image/svg+xml,application/xhtml+xml,application/atom+xmlwill usexmlandapplication/calendar+jsonwill usejson.