Markdown: Fixed headers #1557
Merged
Markdown: Fixed headers #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Nov 28, 2018
| @@ -4,6 +4,9 @@ title 1 | |||
| foobar | |||
| ====== | |||
|
|
|||
| Überschrift | |||
| =========== | |||
There was a problem hiding this comment.
Can we add a test for the example in your PR comment?
Überschrift
-----------
There was a problem hiding this comment.
That, I cannot do because of the way .test files are parsed, so I added a similar test.
There was a problem hiding this comment.
Fair enough. Looks like we had a similar test already but no harm in another.
ggrossetie
pushed a commit
to ggrossetie/prism
that referenced
this pull request
Mar 11, 2019
This PR fixed markdown header of the form: ``` Überschrift ----------- ```
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed markdown header of the form
Überschrift -----------(Example from the German Markdown Wikipedia page.)
This however also embraces the ambiguity of horizontal lines and headers. But Since a single empty line resolves the ambiguity (that is built into markdown! ), I think it's ok.