-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOML support #1488
TOML support #1488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave reviewing the regex here to my co-maintainers, but there's some tests missing here as well (table & comment).
Test were added. I'm looking forward to the review. |
Isn't the label supposed to be |
Yeah, switched to needs review. |
How it is going, I am quite looking forward to this feature. |
@johng-cn |
If we get the conflicts resolved, we can merge this. |
Thanks, @RunDevelopment! |
Add support for [Tom's Obvious, Minimal Language](https://github.com/toml-lang/toml). Some simplifications: 1. The `.`s of dotted keys are not highlighted. This is because the `.` could be inside quotes and checking that isn't easy. 2. There is no distinction between table `[foo]` and array `[[foo]]`. `foo` will be highlighted as `table` in both cases.
This PR adds support for Tom's Obvious, Minimal Language.
I made some simplifications:
.
s of dotted keys are not highlighted. This is because the.
could be inside quotes and checking that isn't easy.[foo]
and array[[foo]]
.foo
will be highlighted astable
in both cases.This PR resolves #1436