Download page #1484
Merged
Download page #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
requested changes
Jul 21, 2018
| form label input { | ||
| margin-right: .7em; | ||
| margin-left: -1.7em; | ||
| } |
There was a problem hiding this comment.
The CSS you added appears indented further than the code around it.
There was a problem hiding this comment.
Well, because it is about elements inside form label, so it gets indented.
This practice can also be seen further down below.
download.html
Outdated
| form input { | ||
| margin-right: .7em; | ||
| } | ||
| form label > *:nth-child(2) { |
There was a problem hiding this comment.
This selector is really brittle. Is there a better way of styling this?
There was a problem hiding this comment.
@mAAdhaTTah Fixed
mAAdhaTTah
approved these changes
Jul 21, 2018
|
Thanks! |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates awkward word breaks.
It also better aligns checkboxes and text for a cleaner look.
I also disabled
hyphensfor the owners of plugins because I don't want to see these names chopped into pieces.I have tested it on Chrome and FireFox.
Before
After