Mark operator like functions as functions in scheme #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Mar 2, 2019
There was a problem hiding this comment.
Sorry for the delay @jcubic!
The changes look good, just a small nit.
|
Updated the code as requested, tests are passing (it seems that travis is enabled only on gh-pages). |
|
Thank you! I don't know why Travis is taking the day off but it should test your branch. |
RunDevelopment
approved these changes
Mar 3, 2019
|
Perfect! Thank you for contributing! |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one more issue fix found in #1451
this one mark
(** 10)as function not operator*and then blank* there is
(?=\s)|$in operator so it match for space look ahead but also end of the string so it match operator test file. I've also added the same to functions so it's highlighted when you start typing function call like(funthis will be mark as function.