Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lang regex on File Highlight plugin #1399

Merged
merged 1 commit into from
Apr 22, 2018
Merged

Simplify lang regex on File Highlight plugin #1399

merged 1 commit into from
Apr 22, 2018

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 18, 2018

Similar to #854.

@Golmote
Copy link
Contributor

Golmote commented Apr 22, 2018

This is a weird one. It seems I originally introduced this regexp in this file. My guess is that I copy-pasted it from the file prism-core where it's also used currently (Edit: no it's not...).
@LeaVerou It appears you did this change a long time ago. Would you by any chance remember what this negative look-ahead assertion was for?

@valtlai
Copy link
Contributor Author

valtlai commented Apr 22, 2018

@Golmote See #853 (comment).

@Golmote
Copy link
Contributor

Golmote commented Apr 22, 2018

Oh! And I didn't even realize I was not looking at the current version of prism-core in my previous comment. 😅

Alright then! Thanks!

@Golmote Golmote merged commit 7bc9a4a into PrismJS:gh-pages Apr 22, 2018
@valtlai valtlai deleted the lang-regex branch June 4, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants