Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrismJS is not rendering Eiffel correctly in one particular instance #1379

Closed
finnianr opened this issue Apr 6, 2018 · 4 comments
Closed

Comments

@finnianr
Copy link

finnianr commented Apr 6, 2018

Generally I find PrismJS works well for Eiffel but I am having trouble with one particular class called EL_ZSTRING. See this web page: http://www.eiffel-loop.com/library/base/text/string/zstring/el_zstring.html

The syntax highlighting starts to fail at the line:

item alias "[]", at alias "@" (i: INTEGER): CHARACTER_32 assign put

This is a rather important class in my libraries so I would appreciate to have the syntax highlighting working. I suspect it might have something to do with the alias string

"[]"

This is because this construct also indicates an unescaped string similar to the way a triple quote works in Python. For example

xml: STRING = "[
   <?xml version="1.0" encoding="utf-8">
   <empty/>
]"

Unfortunately there is no version information in the Prism code.

@Golmote
Copy link
Contributor

Golmote commented Apr 7, 2018

Hi! Thanks for reporting. The issue should be fixed now.

@finnianr
Copy link
Author

finnianr commented Apr 7, 2018

Many thanks for the fix.
BTW, I would like to offer a suggestion. The most popular Eiffel IDE (EiffelStudio) highlights Eiffel class names with the color blue. Screenshot If PrismJS could do the same it would be fantastic. This should be relatively easy to achieve as any identifier consisting of all upper case letters can be assumed to be a class name. This is a universal naming convention in the Eiffel community.

@Golmote
Copy link
Contributor

Golmote commented Apr 7, 2018

Sounds good. Could you open a new issue for this?

@finnianr
Copy link
Author

finnianr commented Apr 7, 2018

Done! "Class name highlighting for Eiffel #1383"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants