Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Generate components.js from components.json and make it exportable to nodeJS #1354

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Core: Generate components.js from components.json and make it exportable to nodeJS #1354

merged 1 commit into from
Mar 15, 2018

Conversation

Golmote
Copy link
Contributor

@Golmote Golmote commented Mar 12, 2018

This should allow us to consider fixing #972

@mAAdhaTTah
Copy link
Member

Does this include the loadComponents part of that issue? I'm assuming not, but the file is minified, so I can't see the results.

@Golmote
Copy link
Contributor Author

Golmote commented Mar 12, 2018

@mAAdhaTTah No it is not included in this PR. It would probably live in a components/index.js file.

@Golmote Golmote merged commit ba60df0 into PrismJS:gh-pages Mar 15, 2018
@Golmote Golmote deleted the load-components branch March 15, 2018 07:58
@snyk-bot snyk-bot mentioned this pull request May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Golmote @mAAdhaTTah